I like this new feature for a chilling map it's a nice activity for those who don't pvp (and most don't on hotel-styled maps) so gj I clap clap this mod :0
The anti-pvp totem security police of summon is neat but would need some tweaks imo. You need to get 3 fishes while being close to it to get the protection. Since it's compatible (and meant to be played with?) YD Classes, well some classes can easily force you out of the totem's small protection radius. One megawaterS, tornado man, shademan can be enough to push around and disturb fishermen :V
Not only that but some players probably want to move between catches and change fishing location. They need to fish 3 times (~15-20 seconds of standing still like a duck) in that Hyper Bomb size radius without dieing, each time they change location D:
Personnal suggestion ahead - I'd recommend the totem item to be fishable on the very first catch (or even better : Auto just gives it to you directly :P). It's part of the fisherman's material after all alongside the rod
When using it, it could stick like a spiritual chain and follow you everywhere, giving invulnerability and pacifism, for as long as you fished at least 3 times. tl;dr give infinite range to the totem.
To activate PvP mode you'd just need to activate the totem item again to "unlink" you from it. But then you'd have to fish 3 times again to restore the link.
Also what does the Fish_CloverFin fish do? Code says it gives FishLuckBuff, a powerup that lasts 40 seconds, but I can't find anything about what this powerup does :(
OH ye and here is new fish suggestion :]
Name : Psychedelic Jellyfish (it's the one that changes your skin color right)
Color : R a i n b o o o o o
Rarity : Rare (blue border)
Effect : picks a random color in MM8BDM's skin colors (including "charging" colors like atomic fire), changing every 1/6 second or so
OR just do Galaxy man's color scheme
Got some extra suggestions and ideas tho ^^
> The basic fishes you can't use (Bass, Minnow, Salmon, Tetra, etc...) clustering in the CustomInventory slots with no direct use are kind of wonky. A neat thing would be to display your basic fish count in a small part of the screen (bottom left or bottom right corner?) instead of having them in your "usable" inventory. Something like :
(http://i65.tinypic.com/2ro1iea.png)
Now that's just a awful photoshop to help understanding the concept, don't mind the quality. You'd resize this menu so it doesn't eat up a large part of the screen. PLUS, you could make the fish menu disappear when you stop fishing (not using the Rod since 15 seconds would make it fade away. Using the rod again would bring the menu back).
OPTIONALLY, it could also display your fishing level (from 1 to 10, depending on how much fishing upgrades you have)
> You hid the code to generate a random fish :( that's sad, we probably wanted to know more about probabilities...
From my personal testing, I see no difference between having 0 fishing upgrades and 10 upgrades. Does it actually do something? If so is it barely noticeable? (like, -5% common fishes at 10 upgrades?)
Anyway since common fishes are meant to improve fishing level, they are kind of useless when you reach max level.
IMO you thus shouldn't be able to fish common ones when you're at max level.
> Two other suggestions, still about fishing quality :
An "automatic fishing" effect. Throw the Rod, and when it shakes, the rod automatically returns to you without you needing to press item. The effect would still remain after respawning. I would suggest an effect like that for EITHER :
A very rare fish (golden border) fish ;
OR a shared effect for all LVMAX fishermen (when using the 10th fishing upgrade you receive this buff).
> Random idea share for Sea horses : right now they provide 10 uses of a certain projectile/attack, then you run out of them and need to fish them again.
I'd propose to make Seahorses infinite use. But, they'd have a longer cooldown (I was thinking 10 to 15 seconds per seahorse. Or if the cooldown is shared among the Seahorses, I'd rather say 5-8 seconds.)
That makes them more "collectable" and fun to use without having to worry about "wasting" them.
Quite some fishes do something "permanent" (crabs summon something that stay forever, jellyfishes give you a permanant color, shrimps give you permanent aesthetic) so it's fair ^^
> Have the rod's range be a parameter for some fishes. Like, have some fishes (currently or future ones) only be fishable if the rod is thrown far away enough :V
> For the crabs (summoning fishes) : first time you use the crab CustomInventory item could display a translucent unsolid (a ghost) of what you're going to summon in a fixed point in front of you ; using the item again to validate and summon it.
That's a little extra, but for people who don't know what the crab they freshly got is going summon, it can help them, so they don't waste it on a random spot.
hhh