The "How do I make a weapon do that?" thread

[Russel]

Try changing the 1 after the expression to a 2. A_Jump functions have always confused me and sometimes they don't work in ways you think they would...

[TheDoc]

Oh yea it is weird like that isn't it?

Finally it works! Thank you again...but I have one more question
How does the damage property of an actor work? Specifically, is there a difference between putting damage in parentheses and not?

[Ceridran]

Far as I know, you need to put it in parentheses, or it ain't gonna recognize it.

[Russel]

That one actually has a legitimate answer.

By default, there is a damage spread of a randomized value of 1-8 times the given value. In the case of the +STRIFEDAMAGE flag, this value is changed to 1-4 times the given value.
If this value is placed in parenthesis, the randomization is removed.

It's even stated on the wiki, it helps to read.

[TheDoc]

I actually did read that and apparently missed the parentheses part; sorry bout that :? . Thanks tho

[Beed28]

I need help. I'm trying to make a script that checks if the up, down, left or right keys are pressed (and only pressed; not held down) and gives the player a flag item based on which key is pressed for a very brief period. However, I just can't get this working properly, it always acts when the key is held down.

(click to show/hide)

Code: [Select]

script 450 ENTER
{
If(PlayerIsBot(PlayerNumber())){terminate;}

int buttons = GetPlayerInput(-1, INPUT_BUTTONS);
bool keyHold;

if ((buttons == (BT_FORWARD|BT_BACK|BT_MOVELEFT|BT_MOVERIGHT)) & (keyHold == TRUE))
{Delay(1); Restart;}

keyHold = FALSE;

if ((buttons == BT_FORWARD) & (keyHold == FALSE))
{
    GiveInventory("FowardKey",1);
keyHold = TRUE;
Delay(35);
}
if ((buttons == BT_BACK) & (keyHold == FALSE))
{
    GiveInventory("BackKey",1);
keyHold = TRUE;
Delay(35);
}
if ((buttons == BT_LEFT) & (keyHold == FALSE))
{
    GiveInventory("LeftKey",1);
keyHold = TRUE;
Delay(35);
}
if ((buttons == BT_RIGHT) & (keyHold == FALSE))
{
    GiveInventory("RightKey",1);
keyHold = TRUE;
Delay(35);
}

TakeInventory("FowardKey",1);
TakeInventory("BackKey",1);
TakeInventory("LeftKey",1);
TakeInventory("RightKey",1);

Delay(1);
Restart;
}

[Russel]

First off, the check logic on the keys is wrong. Basically what you would want to do is something along the lines of checking if the button you're checking is among the list of buttons being pressed and what you're checking is if the button you're checking is the only button pressed.
In my work in progress kart racing mod for Doom, my button checks used a statement more like this:

Code: [Select]

if(buttons & BT_FORWARD)Also in the given script, your use of "&" needs to be replaced with "&&." I can't find the words to explain this any better than X&Y basically asks "does X contain Y?" rather than a boolean statement saying "X and Y."

Second, I'm having trouble interpreting what you're trying to ask here:

Code: [Select]

if ((buttons == (BT_FORWARD|BT_BACK|BT_MOVELEFT|BT_MOVERIGHT)) & (keyHold == TRUE))It seems like you're checking to see if any of those buttons are pressed, but...that seems unnecessary because you're doing the same thing below anyway?

Third, the delays after the button statements aren't necessary and might actually cause the response time to get reduced should the button direction get changed.

Finally, I would recommend using a while loop over a restart statement, as that reactivates the script rather than keeping it running in the same instance.

[Beed28]

Jeez, I still can't wrap my head around all this. For the second one, it's to try and prevent the keys from being registered held down, but it didn't work.

[Russel]

Why not just use the boolean you established at the beginning of the script, then?

I mean it's set up to set keypressed to true if any of the valid keys have been pressed, so why need to check if they were already pressed again?

[Beed28]

Still very confused. Is there nothing out there I can use for a reference?

The only examples on the ZDoom wiki doesn't look like any examples of button pressing (and not holding).

[Russel]

idk man I guess you could do something similar to...

Code: [Select]

script  ENTER
{
If(PlayerIsBot(PlayerNumber())){terminate;}

int keyPressed = 0;

While(true)
{
int buttons = GetPlayerInfo(-1, INPUT_BUTTONS);
if(buttons & BT_FORWARD)
{
if(keypressed==0)
{
GiveInventory("FowardKey",1);
TakeInventory("BackKey", 1);
//The other take lines should be here too
keypressed=1;
}
}


}
}

[Beed28]

Well, I asked on the ZDoom forum, and got a working solution at last.

Thank you for the help, anyway.

[Beed28]

New situation. How can I make a shield weapon be able to absorb hits while protecting the user from damage?

[Megaman94]

New situation. How can I make a shield weapon be able to absorb hits while protecting the user from damage?

Doesn't the leaf shield do that?

[Beed28]

New situation. How can I make a shield weapon be able to absorb hits while protecting the user from damage?

Doesn't the leaf shield do that?

Nope. Leaf Shield reflects certain projectiles. Skull Barrier makes you invincible. Plant Barrier heals you. Junk Shield gives you armour, not exactly what I'm looking for.